Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

move rewards update loop out of zinnia loop#462

Merged
bajtos merged 3 commits intomainfrom
refactor/update-rewards-loop
May 14, 2024
Merged

move rewards update loop out of zinnia loop#462
bajtos merged 3 commits intomainfrom
refactor/update-rewards-loop

Conversation

@juliangruber
Copy link
Copy Markdown
Member

@juliangruber juliangruber commented May 14, 2024 •
edited by bajtos
Loading

@juliangruber juliangruber requested a review from bajtos May 14, 2024 13:18
bajtos
bajtos approved these changes May 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

bajtos
bajtos suggested changes May 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing 😢

bajtos added 2 commits May 14, 2024 16:30
@bajtos
fix: initialise lastRewardsScheduledForAddress
ac445c0 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
fix: print full details for event handler errors
1672f28 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
Copy link
Copy Markdown
Member

bajtos commented May 14, 2024

Added two more commits. The first one makes it easier to troubleshoot the problem, the second one fixes the bug.

@bajtos bajtos merged commit bdb853f into main May 14, 2024
@bajtos bajtos deleted the refactor/update-rewards-loop branch May 14, 2024 14:35
@bajtos bajtos mentioned this pull request May 14, 2024
Merged
@sentry
Copy link
Copy Markdown

sentry Bot commented May 14, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ExecaError: Command failed with exit code 1: /usr/src/app/modules/zinnia/zinniad voyager/main.js sendSaturnRequest(voyager) View Issue
  • ‼️ AbortError: This operation was aborted runUpdateSourceFilesLoop(zinnia) View Issue
  • ‼️ ExecaError: Command failed with exit code 1: /usr/src/app/modules/zinnia/zinniad voyager/main.js sendSaturnRequest(voyager) View Issue
  • ‼️ ExecaError: Command failed with exit code 1: '/Applications/Filecoin Station.app/Contents/Resources/core/modu... sendSaturnRequest(voyager) View Issue
  • ‼️ ExecaError: Command failed with exit code 1: "C:\Program Files\Filecoin Station\resources\core\modules\zinnia... sendSaturnRequest(voyager) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bajtos bajtos bajtos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliangruber @bajtos